Skip to content

fixes production code-splitting#685

Merged
lazarusA merged 2 commits into
mainfrom
la/fix_prod
Jul 17, 2026
Merged

fixes production code-splitting#685
lazarusA merged 2 commits into
mainfrom
la/fix_prod

Conversation

@lazarusA

@lazarusA lazarusA commented Jul 17, 2026

Copy link
Copy Markdown
Member

closes #684

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the data fetching and texture generation pipeline to support variable-specific arrays, passing variables, shapes, and strides dynamically to GetCurrentArray. It also updates ArrayToTexture to return texture data, fixes the depth ratio calculation for point-cloud plots, and refactors array decompression. The review feedback highlights several critical improvement opportunities: addressing potential RangeError crashes during Float16Array instantiation due to unaligned byte offsets, adding defensive guards for missing store variables or uninitialized analysisArray states, and removing a redundant await on a synchronous function call.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/utils/HelperFuncs.ts Outdated
Comment thread src/components/zarr/utils.ts
Comment thread src/utils/HelperFuncs.ts
Comment thread src/components/plots/AnalysisWG.tsx Outdated
Comment thread src/components/plots/AxisLines.tsx
Comment thread src/components/plots/FlatMap.tsx Outdated
Comment thread src/components/plots/FlatMap.tsx Outdated
Comment thread src/components/plots/Sphere.tsx Outdated
Comment thread src/components/plots/UVCube.tsx Outdated
@lazarusA
lazarusA merged commit 2d33887 into main Jul 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analysis is broken

1 participant